Re: [PATCH v3 23/24] tests/docker: add zstdtools to the images (!AWAITING UPSTREAM)

[Philippe Mathieu-Daudé]

On 1/3/23 11:59, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > On 28/2/23 20:06, Alex Bennée wrote:
> > > We need this to be able to run the tuxrun_baseline tests in CI which
> > > in turn helps us reduce overhead running other tests.
> > > [See https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/361]
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > ---
> > >    tests/docker/dockerfiles/alpine.docker                | 1 +
> > >    tests/docker/dockerfiles/centos8.docker               | 3 ++-
> > >    tests/docker/dockerfiles/debian-amd64-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/debian-amd64.docker          | 3 ++-
> > >    tests/docker/dockerfiles/debian-arm64-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/debian-armel-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/debian-armhf-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/debian-mips64el-cross.docker | 3 ++-
> > >    tests/docker/dockerfiles/debian-mipsel-cross.docker   | 3 ++-
> > >    tests/docker/dockerfiles/debian-ppc64el-cross.docker  | 3 ++-
> > >    tests/docker/dockerfiles/debian-s390x-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/fedora-win32-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/fedora-win64-cross.docker    | 3 ++-
> > >    tests/docker/dockerfiles/fedora.docker                | 3 ++-
> > >    tests/docker/dockerfiles/opensuse-leap.docker         | 3 ++-
> > >    tests/docker/dockerfiles/ubuntu2004.docker            | 3 ++-
> > >    tests/docker/dockerfiles/ubuntu2204.docker            | 3 ++-
> > >    tests/lcitool/projects/qemu.yml                       | 1 +
> > >    18 files changed, 34 insertions(+), 16 deletions(-)
> >
> > You simply ran 'lcitool-refresh', right? (not obvious from the
> > commit desc).
> >
> > If #361 got merged, this patch should also change the
> > tests/lcitool/libvirt-ci submodule to include it, isn't it?
>
> Yes - I've already done that in my PR branch.

Then:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

If you don't mind, please amend:
"refresh the generated files by running 'make lcitool-refresh'"
to the description.