Re: [PULL v2 00/24] testing updates (gitlab, cirrus, docker, avocado, windows)

[Alex Bennée]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Thu, 2 Mar 2023 at 11:15, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> On 2/3/23 11:56, Peter Maydell wrote:
>> > On Wed, 1 Mar 2023 at 19:47, Alex Bennée <alex.bennee@linaro.org> wrote:
>> >>
>> >>  From the other thread:
>> >>
>> >> I think the underlying config needs updating:
>> >>
>> >>    .git/modules/tests/fp/berkeley-testfloat-3/config
>> >>
>> >> I'm surprised the git config for submodules doesn't carry the metadata.
>> >
>> > Yeah, in my local repo that I merge stuff with that file
>> > does still have a github URL:
>> > url = git://github.com/cota/berkeley-testfloat-3
>> >
>> > So I guess my questions are:
>> >   (1) why hasn't this been a problem up til now ?
>> >   (2) does this mean that if I merge this then everybody will
>> >       need to manually go in and update this file somehow
>> >       to be able to pull the updated qemu master ?
>>
>> I assume you are not passing --disable-git-update or
>> --with-git-submodules to ./configure.
>
> No, I don't do that. But this problem happens before we
> get anywhere near configure, when I try to do the
> 'git fetch' of the main repo!

c.f:

  ➜  git submodule foreach --recursive git config --get remote.origin.url

  Entering 'dtc'
  https://git.qemu.org/git/dtc.git
  Entering 'meson'
  https://github.com/mesonbuild/meson/
  Entering 'roms/QemuMacDrivers'
  https://git.qemu.org/git/QemuMacDrivers.git
  Entering 'roms/SLOF'
  https://git.qemu.org/git/SLOF.git
  Entering 'roms/ipxe'
  https://git.qemu.org/git/ipxe.git
  Entering 'roms/openbios'
  https://git.qemu.org/git/openbios.git
  Entering 'roms/opensbi'
  https://git.qemu.org/git/opensbi.git
  Entering 'roms/qboot'
  https://github.com/bonzini/qboot
  Entering 'roms/qemu-palcode'
  https://git.qemu.org/git/qemu-palcode.git
  Entering 'roms/seabios'
  https://git.qemu.org/git/seabios.git/
  Entering 'roms/seabios-hppa'
  https://git.qemu.org/git/seabios-hppa.git
  Entering 'roms/skiboot'
  https://git.qemu.org/git/skiboot.git
  Entering 'roms/u-boot'
  https://git.qemu.org/git/u-boot.git
  Entering 'roms/u-boot-sam460ex'
  https://git.qemu.org/git/u-boot-sam460ex.git
  Entering 'roms/vbootrom'
  https://gitlab.com/qemu-project/vbootrom.git
  Entering 'subprojects/libvfio-user'
  https://gitlab.com/qemu-project/libvfio-user.git
  Entering 'tests/fp/berkeley-softfloat-3'
  https://github.com/cota/berkeley-softfloat-3
  Entering 'tests/fp/berkeley-testfloat-3'
  https://gitlab.com/qemu-project/berkeley-testfloat-3.git
  Entering 'tests/lcitool/libvirt-ci'
  http://gitlab.com/libvirt/libvirt-ci
  Entering 'ui/keycodemapdb'
  https://git.qemu.org/git/keycodemapdb.git

vs what .gitmodules says:

➜  cat .gitmodules | grep url
        url = https://gitlab.com/qemu-project/seabios.git/
        url = https://gitlab.com/qemu-project/SLOF.git
        url = https://gitlab.com/qemu-project/ipxe.git
        url = https://gitlab.com/qemu-project/openbios.git
        url = https://gitlab.com/qemu-project/qemu-palcode.git
        url = https://gitlab.com/qemu-project/dtc.git
        url = https://gitlab.com/qemu-project/u-boot.git
        url = https://gitlab.com/qemu-project/skiboot.git
        url = https://gitlab.com/qemu-project/QemuMacDrivers.git
        url = https://gitlab.com/qemu-project/keycodemapdb.git
        url = https://gitlab.com/qemu-project/seabios-hppa.git
        url = https://gitlab.com/qemu-project/u-boot-sam460ex.git
        url = https://gitlab.com/qemu-project/berkeley-testfloat-3.git
        url = https://gitlab.com/qemu-project/berkeley-softfloat-3.git
        url = https://gitlab.com/qemu-project/edk2.git
        url =   https://gitlab.com/qemu-project/opensbi.git
        url = https://gitlab.com/qemu-project/qboot.git
        url = https://gitlab.com/qemu-project/meson.git
        url = https://gitlab.com/qemu-project/vbootrom.git
        url = https://gitlab.com/libvirt/libvirt-ci.git
        url = https://gitlab.com/qemu-project/libvfio-user.git

>
> thanks
> -- PMM


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro