Re: [RFC PATCH v2 05/44] target/loongarch: Implement vadd/vsub

[Richard Henderson]

On 3/27/23 20:05, Song Gao wrote:
> This patch includes:
> - VADD.{B/H/W/D/Q};
> - VSUB.{B/H/W/D/Q}.
>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/disas.c                    | 23 ++++++++++++
>   target/loongarch/helper.h                   |  4 +++
>   target/loongarch/insn_trans/trans_lsx.c.inc | 40 +++++++++++++++++++++
>   target/loongarch/insns.decode               | 22 ++++++++++++
>   target/loongarch/lsx_helper.c               | 25 +++++++++++++
>   target/loongarch/translate.c                |  7 ++++
>   6 files changed, 121 insertions(+)

I did mention that you could use tcg_gen_{add,sub}2_i64 to perform the 128-bit arithmetic 
inline.  But that could be improved later.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~