[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/48] igb: Do not require CTRL.VME for tx VLAN tagging
From: |
Akihiko Odaki |
Subject: |
[PATCH v4 05/48] igb: Do not require CTRL.VME for tx VLAN tagging |
Date: |
Wed, 26 Apr 2023 19:36:33 +0900 |
While the datasheet of e1000e says it checks CTRL.VME for tx VLAN
tagging, igb's datasheet has no such statements. It also says for
"CTRL.VLE":
> This register only affects the VLAN Strip in Rx it does not have any
> influence in the Tx path in the 82576.
(Appendix A. Changes from the 82575)
There is no "CTRL.VLE" so it is more likely that it is a mistake of
CTRL.VME.
Fixes: fba7c3b788 ("igb: respect VMVIR and VMOLR for VLAN")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index dbd1192a8e..96a118b6c1 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -402,7 +402,7 @@ igb_tx_insert_vlan(IGBCore *core, uint16_t qn, struct
igb_tx *tx,
}
}
- if (insert_vlan && e1000x_vlan_enabled(core->mac)) {
+ if (insert_vlan) {
net_tx_pkt_setup_vlan_header_ex(tx->tx_pkt, vlan,
core->mac[VET] & 0xffff);
}
--
2.40.0
- [PATCH v4 00/48] igb: Fix for DPDK, Akihiko Odaki, 2023/04/26
- [PATCH v4 01/48] hw/net/net_tx_pkt: Decouple implementation from PCI, Akihiko Odaki, 2023/04/26
- [PATCH v4 02/48] hw/net/net_tx_pkt: Decouple interface from PCI, Akihiko Odaki, 2023/04/26
- [PATCH v4 03/48] e1000x: Fix BPRC and MPRC, Akihiko Odaki, 2023/04/26
- [PATCH v4 04/48] igb: Fix Rx packet type encoding, Akihiko Odaki, 2023/04/26
- [PATCH v4 05/48] igb: Do not require CTRL.VME for tx VLAN tagging,
Akihiko Odaki <=
- [PATCH v4 06/48] igb: Clear IMS bits when committing ICR access, Akihiko Odaki, 2023/04/26
- [PATCH v4 07/48] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols(), Akihiko Odaki, 2023/04/26
- [PATCH v4 08/48] e1000e: Always copy ethernet header, Akihiko Odaki, 2023/04/26
- [PATCH v4 09/48] igb: Always copy ethernet header, Akihiko Odaki, 2023/04/26
- [PATCH v4 10/48] Fix references to igb Avocado test, Akihiko Odaki, 2023/04/26
- [PATCH v4 11/48] tests/avocado: Remove unused imports, Akihiko Odaki, 2023/04/26
- [PATCH v4 12/48] tests/avocado: Remove test_igb_nomsi_kvm, Akihiko Odaki, 2023/04/26
- [PATCH v4 13/48] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info, Akihiko Odaki, 2023/04/26
- [PATCH v4 14/48] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/04/26
- [PATCH v4 15/48] e1000x: Share more Rx filtering logic, Akihiko Odaki, 2023/04/26