Re: [PATCH] tests: vhost-user-test: release mutex on protocol violation

[Thomas Huth]

On 27/04/2023 14.54, Paolo Bonzini wrote:
> chr_read() is printing an error message and returning with s->data_mutex taken.
> This can potentially cause a hang.  Reported by Coverity.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/qtest/vhost-user-test.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index bf9f7c4248ca..e4f95b2858f0 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -351,7 +351,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int 
> size)
>           if (size != msg.size) {
>               qos_printf("%s: Wrong message size received %d != %d\n",
>                          __func__, size, msg.size);
> -            return;
> +            goto out;
>           }
>       }
>   
> @@ -509,6 +509,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
>           break;
>       }
>   
> +out:
>       g_mutex_unlock(&s->data_mutex);
>   }
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>