[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/13] bcm2835_property: disable reentrancy detection for iomem
From: |
Thomas Huth |
Subject: |
[PULL 11/13] bcm2835_property: disable reentrancy detection for iomem |
Date: |
Fri, 28 Apr 2023 11:43:44 +0200 |
From: Alexander Bulekov <alxndr@bu.edu>
As the code is designed for re-entrant calls from bcm2835_property to
bcm2835_mbox and back into bcm2835_property, mark iomem as
reentrancy-safe.
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230427211013.2994127-7-alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/misc/bcm2835_property.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 890ae7bae5..de056ea2df 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -382,6 +382,13 @@ static void bcm2835_property_init(Object *obj)
memory_region_init_io(&s->iomem, OBJECT(s), &bcm2835_property_ops, s,
TYPE_BCM2835_PROPERTY, 0x10);
+
+ /*
+ * bcm2835_property_ops call into bcm2835_mbox, which in-turn reads from
+ * iomem. As such, mark iomem as re-entracy safe.
+ */
+ s->iomem.disable_reentrancy_guard = true;
+
sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem);
sysbus_init_irq(SYS_BUS_DEVICE(s), &s->mbox_irq);
}
--
2.31.1
- [PULL 06/13] memory: prevent dma-reentracy issues, (continued)
- [PULL 06/13] memory: prevent dma-reentracy issues, Thomas Huth, 2023/04/28
- [PULL 05/13] tests: vhost-user-test: release mutex on protocol violation, Thomas Huth, 2023/04/28
- [PULL 07/13] async: Add an optional reentrancy guard to the BH API, Thomas Huth, 2023/04/28
- [PULL 04/13] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI, Thomas Huth, 2023/04/28
- [PULL 02/13] hw/rdma: Remove unused macros PG_DIR_SZ and PG_TBL_SZ, Thomas Huth, 2023/04/28
- [PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks, Thomas Huth, 2023/04/28
- [PULL 09/13] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded, Thomas Huth, 2023/04/28
- [PULL 13/13] apic: disable reentrancy detection for apic-msi, Thomas Huth, 2023/04/28
- [PULL 12/13] raven: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- [PULL 10/13] lsi53c895a: disable reentrancy detection for script RAM, Thomas Huth, 2023/04/28
- [PULL 11/13] bcm2835_property: disable reentrancy detection for iomem,
Thomas Huth <=
- Re: [PULL 00/13] DMA reentrancy fixes and other misc patches, Richard Henderson, 2023/04/28