Re: [PATCH 00/26] Migration PULL 2023-07-24

[Thomas Huth]

On 24/07/2023 15.06, Juan Quintela wrote:
> Hi
>
> This is the migration PULL request.

Maybe it would better to use "PULL" instead of "PATCH" in the subject?

> Now a not on CI, thas has been really bad.  After too many problems
> with last PULLS, I decided to learn to use qemu CI.  On one hand, it
> is not so difficult, even I can use it O:-)
>
> On the other hand, the amount of problems that I got is inmense.  Some
> of them dissapear when I rerun the checks, but I never know if it is
> my PULL request, the CI system or the tests themselves.

I normally peek at https://gitlab.com/qemu-project/qemu/-/pipelines to see 
whether the problem occurred in one of the last staging CI runs already ... 
or I push the master branch to my own repo to see whether it reproduces with 
a clean state. That often helps in judging whether it's a new problem or a 
pre-existing one.

> This (last) patch is not part of the PULL request, but I have found
> that it _always_ makes gcov fail.  I had to use bisect to find where
> the problem was.
>
> https://gitlab.com/juan.quintela/qemu/-/jobs/4571878922
>
> I could use help to know how a change in test/qtest/migration-test.c
> can break block layer tests, I am all ears.
>
> Yes, I tried several times.  It always fails on that patch.  The
> passes with flying colors.

Can you reproduce it locally by running "make check-block"?

The tests/qemu-iotests/tests/copy-before-write test seems to be doing some 
things with snapshots ... maybe that's related?

 Thomas