[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 09/24] linux-user: Do nothing if too small brk is specified
From: |
Richard Henderson |
Subject: |
[PATCH v9 09/24] linux-user: Do nothing if too small brk is specified |
Date: |
Fri, 4 Aug 2023 15:00:17 -0700 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Linux 6.4.7 does nothing when a value smaller than the initial brk is
specified.
Fixes: 86f04735ac ("linux-user: Fix brk() to release pages")
Reviewed-by: Helge Deller <deller@gmx.de>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20230802071754.14876-6-akihiko.odaki@daynix.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f64024273f..e1436a3962 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -820,14 +820,14 @@ abi_long do_brk(abi_ulong brk_val)
/* brk pointers are always untagged */
- /* return old brk value if brk_val unchanged or zero */
- if (!brk_val || brk_val == target_brk) {
+ /* return old brk value if brk_val unchanged */
+ if (brk_val == target_brk) {
return target_brk;
}
/* do not allow to shrink below initial brk value */
if (brk_val < initial_target_brk) {
- brk_val = initial_target_brk;
+ return target_brk;
}
new_brk = TARGET_PAGE_ALIGN(brk_val);
--
2.34.1
- [PATCH v9 02/24] accel/tcg: Issue wider aligned i/o in do_{ld, st}_mmio_*, (continued)
- [PATCH v9 02/24] accel/tcg: Issue wider aligned i/o in do_{ld, st}_mmio_*, Richard Henderson, 2023/08/04
- [PATCH v9 08/24] linux-user: Use MAP_FIXED_NOREPLACE for do_brk(), Richard Henderson, 2023/08/04
- [PATCH v9 13/24] linux-user: Adjust task_unmapped_base for reserved_va, Richard Henderson, 2023/08/04
- [PATCH v9 07/24] linux-user: Do not call get_errno() in do_brk(), Richard Henderson, 2023/08/04
- [PATCH v9 19/24] linux-user: Properly set image_info.brk in flatload, Richard Henderson, 2023/08/04
- [PATCH v9 01/24] accel/tcg: Adjust parameters and locking with do_{ld, st}_mmio_*, Richard Henderson, 2023/08/04
- [PATCH v9 06/24] linux-user: Fix MAP_FIXED_NOREPLACE on old kernels, Richard Henderson, 2023/08/04
- [PATCH v9 10/24] linux-user: Do not align brk with host page size, Richard Henderson, 2023/08/04
- [PATCH v9 15/24] linux-user: Define ELF_ET_DYN_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/04
- [PATCH v9 21/24] linux-user: Do not adjust zero_bss for host page size, Richard Henderson, 2023/08/04
- [PATCH v9 09/24] linux-user: Do nothing if too small brk is specified,
Richard Henderson <=
- [PATCH v9 12/24] bsd-user: Remove last_brk, Richard Henderson, 2023/08/04
- [PATCH v9 14/24] linux-user: Define TASK_UNMAPPED_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/04
- [PATCH v9 17/24] linux-user: Use elf_et_dyn_base for ET_DYN with interpreter, Richard Henderson, 2023/08/04
- [PATCH v9 22/24] linux-user: Use zero_bss for PT_LOAD with no file contents too, Richard Henderson, 2023/08/04
- [PATCH v9 04/24] gdbstub: use 0 ("any process") on packets with no PID, Richard Henderson, 2023/08/04
- [PATCH v9 03/24] accel/tcg: Do not issue misaligned i/o, Richard Henderson, 2023/08/04
- [PATCH v9 11/24] linux-user: Remove last_brk, Richard Henderson, 2023/08/04
- [PATCH v9 05/24] linux-user: Unset MAP_FIXED_NOREPLACE for host, Richard Henderson, 2023/08/04
- [PATCH v9 16/24] linux-user: Use MAP_FIXED_NOREPLACE for initial image mmap, Richard Henderson, 2023/08/04
- [PATCH v9 18/24] linux-user: Adjust initial brk when interpreter is close to executable, Richard Henderson, 2023/08/04