[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 20/24] linux-user: Do not adjust image mapping for host page size
From: |
Richard Henderson |
Subject: |
[PULL 20/24] linux-user: Do not adjust image mapping for host page size |
Date: |
Sat, 5 Aug 2023 20:37:11 -0700 |
Remove TARGET_ELF_EXEC_PAGESIZE, and 3 other TARGET_ELF_PAGE* macros
based off of that. Rely on target_mmap to handle guest vs host page
size mismatch.
Tested-by: Helge Deller <deller@gmx.de>
Reviewed-by: Helge Deller <deller@gmx.de>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index fa0c9ace8e..e853a4ab33 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1959,15 +1959,6 @@ struct exec
#define ZMAGIC 0413
#define QMAGIC 0314
-/* Necessary parameters */
-#define TARGET_ELF_EXEC_PAGESIZE \
- (((eppnt->p_align & ~qemu_host_page_mask) != 0) ? \
- TARGET_PAGE_SIZE : MAX(qemu_host_page_size, TARGET_PAGE_SIZE))
-#define TARGET_ELF_PAGELENGTH(_v) ROUND_UP((_v), TARGET_ELF_EXEC_PAGESIZE)
-#define TARGET_ELF_PAGESTART(_v) ((_v) & \
- ~(abi_ulong)(TARGET_ELF_EXEC_PAGESIZE-1))
-#define TARGET_ELF_PAGEOFFSET(_v) ((_v) & (TARGET_ELF_EXEC_PAGESIZE-1))
-
#define DLINFO_ITEMS 16
static inline void memcpy_fromfs(void * to, const void * from, unsigned long n)
@@ -3240,8 +3231,8 @@ static void load_elf_image(const char *image_name, int
image_fd,
}
vaddr = load_bias + eppnt->p_vaddr;
- vaddr_po = TARGET_ELF_PAGEOFFSET(vaddr);
- vaddr_ps = TARGET_ELF_PAGESTART(vaddr);
+ vaddr_po = vaddr & ~TARGET_PAGE_MASK;
+ vaddr_ps = vaddr & TARGET_PAGE_MASK;
vaddr_ef = vaddr + eppnt->p_filesz;
vaddr_em = vaddr + eppnt->p_memsz;
@@ -3251,7 +3242,7 @@ static void load_elf_image(const char *image_name, int
image_fd,
* but no backing file segment.
*/
if (eppnt->p_filesz != 0) {
- vaddr_len = TARGET_ELF_PAGELENGTH(eppnt->p_filesz + vaddr_po);
+ vaddr_len = eppnt->p_filesz + vaddr_po;
error = target_mmap(vaddr_ps, vaddr_len, elf_prot,
MAP_PRIVATE | MAP_FIXED,
image_fd, eppnt->p_offset - vaddr_po);
@@ -3267,7 +3258,7 @@ static void load_elf_image(const char *image_name, int
image_fd,
zero_bss(vaddr_ef, vaddr_em, elf_prot);
}
} else if (eppnt->p_memsz != 0) {
- vaddr_len = TARGET_ELF_PAGELENGTH(eppnt->p_memsz + vaddr_po);
+ vaddr_len = eppnt->p_memsz + vaddr_po;
error = target_mmap(vaddr_ps, vaddr_len, elf_prot,
MAP_PRIVATE | MAP_FIXED | MAP_ANONYMOUS,
-1, 0);
--
2.34.1
- [PULL 10/24] linux-user: Do not align brk with host page size, (continued)
- [PULL 10/24] linux-user: Do not align brk with host page size, Richard Henderson, 2023/08/05
- [PULL 11/24] linux-user: Remove last_brk, Richard Henderson, 2023/08/05
- [PULL 12/24] bsd-user: Remove last_brk, Richard Henderson, 2023/08/05
- [PULL 13/24] linux-user: Adjust task_unmapped_base for reserved_va, Richard Henderson, 2023/08/05
- [PULL 14/24] linux-user: Define TASK_UNMAPPED_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/05
- [PULL 15/24] linux-user: Define ELF_ET_DYN_BASE in $guest/target_mman.h, Richard Henderson, 2023/08/05
- [PULL 17/24] linux-user: Use elf_et_dyn_base for ET_DYN with interpreter, Richard Henderson, 2023/08/05
- [PULL 18/24] linux-user: Adjust initial brk when interpreter is close to executable, Richard Henderson, 2023/08/05
- [PULL 16/24] linux-user: Use MAP_FIXED_NOREPLACE for initial image mmap, Richard Henderson, 2023/08/05
- [PULL 19/24] linux-user: Properly set image_info.brk in flatload, Richard Henderson, 2023/08/05
- [PULL 20/24] linux-user: Do not adjust image mapping for host page size,
Richard Henderson <=
- [PULL 21/24] linux-user: Do not adjust zero_bss for host page size, Richard Henderson, 2023/08/05
- [PULL 22/24] linux-user: Use zero_bss for PT_LOAD with no file contents too, Richard Henderson, 2023/08/05
- [PULL 24/24] linux-user/elfload: Set V in ELF_HWCAP for RISC-V, Richard Henderson, 2023/08/05
- [PULL 23/24] accel/tcg: Call save_iotlb_data from io_readx as well., Richard Henderson, 2023/08/05
- Re: [PULL 00/24] tcg + linux-user queue for 8.1-rc3, Richard Henderson, 2023/08/06
- Failing avocado tests in CI (was: Re: [PULL 00/24] tcg + linux-user queue for 8.1-rc3), Thomas Huth, 2023/08/23