Re: [PATCH] Fix scripts/checkpatch.py style failures.

[Peter Maydell]

On Sat, 5 Aug 2023 at 17:44, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 05.08.2023 15:51, Nathan Egge пишет:
> > From: "Nathan Egge" <negge@xiph.org>
> >
> > Signed-off-by: Nathan Egge <negge@xiph.org>
>
> This needs at least some meaningful subject prefix.
> With the subject like it is now, it feels like the
> patch is about fixing checkpatch.py script itself.
>
> Something like:
>
>   linux-user/syscall.c: fix coding-style issue (space-around-or)
>
> I think one of the two places should be fixed in a
> patch which touches this place in tcg-next series
> instead of separately.

Also, this specific area of code (brk handling) is currently
being worked on quite heavily. I'm pretty sure there's a patchset
on list which touches these specific lines of code (and might
well have fixed the style issue in passing). So we should hold
off on the purely coding-style fixes here until after the dust
has settled on those changes.

thanks
-- PMM