[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.2] hw/s390x/s390-virtio-ccw: Remove superfluous code to
|
From: |
Halil Pasic |
|
Subject: |
Re: [PATCH for-8.2] hw/s390x/s390-virtio-ccw: Remove superfluous code to set the NIC model |
|
Date: |
Tue, 15 Aug 2023 00:52:48 +0200 |
On Fri, 4 Aug 2023 09:35:25 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The check for nd->model being NULL was originally required, but in
> commit e11f463295d95aba ("s390x/virtio: use qemu_check_nic_model()")
> the corresponding code had been replaced by a call to the function
> qemu_check_nic_model() - and this in turn calls qemu_find_nic_model()
> which contains the same check for nd->model being NULL again. So we
> can remove this from the calling site now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>