Re: [PATCH v4 10/25] target/riscv: Use GDBFeature for dynamic XML

[Richard Henderson]

On 8/16/23 07:51, Akihiko Odaki wrote:
> -            if (csr_ops[i].name) {
> -                g_string_append_printf(s, "<reg name=\"%s\"", csr_ops[i].name);
> -            } else {
> -                g_string_append_printf(s, "<reg name=\"csr%03x\"", i);
> +            name = csr_ops[i].name;
> +            if (!name) {
> +                name = g_strdup_printf("csr%03x", i);
>               }

You are now leaking name.


r~