[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 27/67] ui/console: free more QemuConsole resources
From: |
marcandre . lureau |
Subject: |
[PATCH 27/67] ui/console: free more QemuConsole resources |
Date: |
Wed, 30 Aug 2023 13:38:01 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
This code path is probably not executed at this point, since console
aren't being released.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/console.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index ffa68c3a22..3cd4c74eec 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1337,8 +1337,11 @@ qemu_console_finalize(Object *obj)
{
QemuConsole *c = QEMU_CONSOLE(obj);
+ /* TODO: check this code path, and unregister from consoles */
+ g_clear_pointer(&c->device, object_unref);
+ g_clear_pointer(&c->surface, qemu_free_displaysurface);
+ g_clear_pointer(&c->gl_unblock_timer, timer_free);
g_clear_pointer(&c->ui_timer, timer_free);
- /* TODO: should unregister from consoles and free itself */
}
static void
--
2.41.0
- [PATCH 17/67] ui/console: use OBJECT_DEFINE_TYPE for QemuConsole, (continued)
- [PATCH 17/67] ui/console: use OBJECT_DEFINE_TYPE for QemuConsole, marcandre . lureau, 2023/08/30
- [PATCH 18/67] ui/console: change new_console() to use object initialization, marcandre . lureau, 2023/08/30
- [PATCH 20/67] ui/console: instantiate a specific console type, marcandre . lureau, 2023/08/30
- [PATCH 19/67] ui/console: introduce different console objects, marcandre . lureau, 2023/08/30
- [PATCH 21/67] ui/console: register the console from qemu_console_init(), marcandre . lureau, 2023/08/30
- [PATCH 22/67] ui/console: remove new_console(), marcandre . lureau, 2023/08/30
- [PATCH 23/67] ui/console: specialize console_lookup_unused(), marcandre . lureau, 2023/08/30
- [PATCH 24/67] ui/console: update the head from unused QemuConsole, marcandre . lureau, 2023/08/30
- [PATCH 25/67] ui/console: allocate ui_timer in QemuConsole, marcandre . lureau, 2023/08/30
- [PATCH 26/67] ui/vc: move cursor_timer initialization to QemuTextConsole class, marcandre . lureau, 2023/08/30
- [PATCH 27/67] ui/console: free more QemuConsole resources,
marcandre . lureau <=
- [PATCH 28/67] ui/vc: move text fields to QemuTextConsole, marcandre . lureau, 2023/08/30
- [PATCH 29/67] ui/console: move graphic fields to QemuGraphicConsole, marcandre . lureau, 2023/08/30
- [PATCH 30/67] ui/vc: fold text_console_do_init() in vc_chr_open(), marcandre . lureau, 2023/08/30
- [PATCH 31/67] ui/vc: move some text console initialization to qom handlers, marcandre . lureau, 2023/08/30
- [PATCH 32/67] ui/console: simplify getting active_console size, marcandre . lureau, 2023/08/30
- [PATCH 33/67] ui/console: remove need for g_width/g_height, marcandre . lureau, 2023/08/30
- [PATCH 34/67] ui/vc: use common text console surface creation, marcandre . lureau, 2023/08/30
- [PATCH 35/67] ui/console: declare console types in console.h, marcandre . lureau, 2023/08/30
- [PATCH 38/67] ui/console: assert(surface) where appropriate, marcandre . lureau, 2023/08/30
- [PATCH 36/67] ui/console: use QEMU_PIXMAN_COLOR helpers, marcandre . lureau, 2023/08/30