Re: [PATCH v4 15/48] target/loongarch: Implement xvadda

[Richard Henderson]

On 8/30/23 01:48, Song Gao wrote:
> -#define DO_VABS(a)  ((a < 0) ? (-a) : (a))
> -
> -#define DO_VADDA(NAME, BIT, E, DO_OP)                       \
> -void HELPER(NAME)(void *vd, void *vj, void *vk, uint32_t v) \
> -{                                                           \
> -    int i;                                                  \
> -    VReg *Vd = (VReg *)vd;                                  \
> -    VReg *Vj = (VReg *)vj;                                  \
> -    VReg *Vk = (VReg *)vk;                                  \
> -    for (i = 0; i < LSX_LEN/BIT; i++) {                     \
> -        Vd->E(i) = DO_OP(Vj->E(i)) + DO_OP(Vk->E(i));       \
> -    }                                                       \
> +#define DO_VADDA(NAME, BIT, E, DO_OP)                          \
> +void HELPER(NAME)(void *vd, void *vj, void *vk, uint32_t desc) \
> +{                                                              \
> +    int i;                                                     \
> +    VReg *Vd = (VReg *)vd;                                     \
> +    VReg *Vj = (VReg *)vj;                                     \
> +    VReg *Vk = (VReg *)vk;                                     \
> +    int oprsz = simd_oprsz(desc);                              \
> +                                                               \
> +    for (i = 0; i < oprsz / (BIT / 8); i++) {                  \
> +        Vd->E(i) = DO_OP(Vj->E(i)) + DO_OP(Vk->E(i));          \
> +    }                                                          \
>   }

No need to move DO_VABS, and indeed no need to pass it in as DO_OP, because DO_VADDA is 
only ever used with DO_VABS.

With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~