Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

[Mark Cave-Ayland]

On 30/09/2023 22:28, Laszlo Ersek wrote:

> On 9/29/23 09:57, Mark Cave-Ayland wrote:
> > On 26/09/2023 09:00, Marc-André Lureau wrote:
> >
> > > Hi Laszlo
> > >
> > > On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek <lersek@redhat.com> wrote:
> > > > Has this been queued by someone? Both Gerd and Marc-André are "odd
> > > > fixers", so I'm not sure who should be sending a PR with these patches
> > > > (and I don't see a pending PULL at
> > > > <https://lists.gnu.org/archive/html/qemu-devel/2023-09/threads.html>
> > > > with these patch subjects included).
> > >
> > > I have the series in my "ui" branch. I was waiting for a few more
> > > patches to be accumulated. But if someone else takes this first, I'll
> > > drop them.
> >
> > Does this series fix the "../ui/console.c:818: dpy_get_ui_info:
> > Assertion `dpy_ui_info_supported(con)' failed." assert() on startup when
> > using gtk? It would be good to get this fixed in git master soon, as it
> > has been broken for a couple of weeks now, and -display sdl has issues
> > tracking the mouse correctly on my laptop here :(
>
> ... probably not; I've never seen that issue. Can you provide a reproducer?

The environment is a standard Debian bookworm install building QEMU git master with 
QEMU gtk support. The only difference I can think of is that I do all my QEMU builds 
as a separate user, and then export the display to my current user desktop i.e.

As my current user:
  $ xhost +

As my QEMU build user:
  $ export DISPLAY=:1
  $ ./build/qemu-system-sparc
  qemu-system-sparc: ../ui/console.c:818: dpy_get_ui_info: Assertion
 `dpy_ui_info_supported(con)' failed.
  Aborted (core dumped)

> Also, it should be bisectable (over Marc-André's 52-part series I guess).

Indeed. I've just run git bisect and it returns the following:

a92e7bb4cad57cc5c8817fb18fb25650507b69f8 is the first bad commit
commit a92e7bb4cad57cc5c8817fb18fb25650507b69f8
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Tue Sep 12 10:13:01 2023 +0400

    ui: add precondition for dpy_get_ui_info()

    Ensure that it only get called when dpy_ui_info_supported(). The
    function should always return a result. There should be a non-null
    console or active_console.

    Modify the argument to be const as well.

    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Albert Esteve <aesteve@redhat.com>

 include/ui/console.h | 2 +-
 ui/console.c         | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)


ATB,

Mark.