[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 28/47] accel/tcg: Remove env_tlb()
|
From: |
Richard Henderson |
|
Subject: |
[PULL 28/47] accel/tcg: Remove env_tlb() |
|
Date: |
Tue, 3 Oct 2023 10:30:33 -0700 |
From: Anton Johansson <anjo@rev.ng>
The function is no longer used to access the TLB,
and has been replaced by cpu->neg.tlb.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230912153428.17816-9-anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[rth: Merge comment update patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu-all.h | 11 -----------
tcg/aarch64/tcg-target.c.inc | 2 +-
tcg/arm/tcg-target.c.inc | 2 +-
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index 46e494eeba..17c7420543 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -449,15 +449,4 @@ static inline CPUState *env_cpu(CPUArchState *env)
return (void *)env - sizeof(CPUState);
}
-/**
- * env_tlb(env)
- * @env: The architecture environment
- *
- * Return the CPUTLB state associated with the environment.
- */
-static inline CPUTLB *env_tlb(CPUArchState *env)
-{
- return &env_cpu(env)->neg.tlb;
-}
-
#endif /* CPU_ALL_H */
diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index 06ea3c7652..69f2daf2c2 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1679,7 +1679,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
mask_type = (s->page_bits + s->tlb_dyn_max_bits > 32
? TCG_TYPE_I64 : TCG_TYPE_I32);
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {tmp0,tmp1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 8);
tcg_out_insn(s, 3314, LDP, TCG_REG_TMP0, TCG_REG_TMP1, TCG_AREG0,
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index b1d56362a7..a2f60106af 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1420,7 +1420,7 @@ static TCGLabelQemuLdst *prepare_host_addr(TCGContext *s,
HostAddress *h,
ldst->addrlo_reg = addrlo;
ldst->addrhi_reg = addrhi;
- /* Load env_tlb(env)->f[mmu_idx].{mask,table} into {r0,r1}. */
+ /* Load cpu->neg.tlb.f[mmu_idx].{mask,table} into {r0,r1}. */
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, mask) != 0);
QEMU_BUILD_BUG_ON(offsetof(CPUTLBDescFast, table) != 4);
tcg_out_ldrd_8(s, COND_AL, TCG_REG_R0, TCG_AREG0, fast_off);
--
2.34.1
- [PULL 07/47] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG, (continued)
- [PULL 07/47] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG, Richard Henderson, 2023/10/03
- [PULL 16/47] accel/tcg: Move can_do_io to CPUNegativeOffsetState, Richard Henderson, 2023/10/03
- [PULL 21/47] accel/tcg: Remove env_neg(), Richard Henderson, 2023/10/03
- [PULL 24/47] accel/tcg: Modify probe_access_internal() to use CPUState, Richard Henderson, 2023/10/03
- [PULL 19/47] accel/tcg: Replace CPUState.env_ptr with cpu_env(), Richard Henderson, 2023/10/03
- [PULL 18/47] tcg: Rename cpu_env to tcg_env, Richard Henderson, 2023/10/03
- [PULL 23/47] accel/tcg: Modify tlb_*() to use CPUState, Richard Henderson, 2023/10/03
- [PULL 27/47] accel/tcg: Use CPUState in atomicity helpers, Richard Henderson, 2023/10/03
- [PULL 31/47] exec: Make EXCP_FOO definitions target agnostic, Richard Henderson, 2023/10/03
- [PULL 33/47] accel/tcg: Restrict dump_exec_info() declaration, Richard Henderson, 2023/10/03
- [PULL 28/47] accel/tcg: Remove env_tlb(),
Richard Henderson <=
- [PULL 35/47] accel: Rename accel-common.c -> accel-target.c, Richard Henderson, 2023/10/03
- [PULL 36/47] exec: Rename cpu.c -> cpu-target.c, Richard Henderson, 2023/10/03
- [PULL 37/47] exec: Rename target specific page-vary.c -> page-vary-target.c, Richard Henderson, 2023/10/03
- [PULL 34/47] accel: Make accel-blocker.o target agnostic, Richard Henderson, 2023/10/03
- [PULL 39/47] accel/tcg: Make monitor.c a target-agnostic unit, Richard Henderson, 2023/10/03
- [PULL 30/47] accel/tcg: move ld/st helpers to ldst_common.c.inc, Richard Henderson, 2023/10/03
- [PULL 38/47] accel/tcg: Rename target-specific 'internal.h' -> 'internal-target.h', Richard Henderson, 2023/10/03
- [PULL 41/47] accel/tcg: Make cpu-exec-common.c a target agnostic unit, Richard Henderson, 2023/10/03
- [PULL 40/47] accel/tcg: Make icount.o a target agnostic unit, Richard Henderson, 2023/10/03
- [PULL 42/47] tcg: Remove argument to tcg_prologue_init, Richard Henderson, 2023/10/03