[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] hw/intc/apic: Rename x86_cpu_apic_create() -> x86_cpu
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v2 4/5] hw/intc/apic: Rename x86_cpu_apic_create() -> x86_cpu_apic_new() |
|
Date: |
Tue, 3 Oct 2023 16:51:55 -0400 |
On Tue, Oct 03, 2023 at 10:27:27AM +0200, Philippe Mathieu-Daudé wrote:
> x86_cpu_apic_create()'s Error** parameter is unused, drop it.
>
> While there is no convention, QDev methods are usually named
> with _new() / _realize() suffixes. Rename as appropriate.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- Re: [PATCH v2 2/5] hw/i386/apic: Defer error check from apic_get_class to kvm_apic_realize, (continued)
[PATCH v2 3/5] hw/i386/apic: Simplify apic_get_class(), Philippe Mathieu-Daudé, 2023/10/03
[PATCH v2 1/5] hw/intc/apic: Use ERRP_GUARD() in apic_common_realize(), Philippe Mathieu-Daudé, 2023/10/03
[PATCH v2 4/5] hw/intc/apic: Rename x86_cpu_apic_create() -> x86_cpu_apic_new(), Philippe Mathieu-Daudé, 2023/10/03
[PATCH v2 5/5] hw/intc/apic: Pass CPU using QOM link property, Philippe Mathieu-Daudé, 2023/10/03