|
| From: | Juan Quintela |
| Subject: | Re: [PATCH v7 05/15] python/qemu: rename command() to cmd() |
| Date: | Mon, 09 Oct 2023 11:52:37 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> Use a shorter name. We are going to move in iotests from qmp() to
> command() where possible. But command() is longer than qmp() and don't
> look better. Let's rename.
I feel your pain O:-)
> You can simply grep for '\.command(' and for 'def command(' to check
> that everything is updated (command() in tests/docker/docker.py is
> unrelated).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> [vsementsov: also update three occurrences in
> tests/avocado/machine_aspeed.py and keep r-b]
Reviewed-by: Juan Quintela <quintela@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |