Re: [PATCH V3 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

[David Hildenbrand]

> > kvm_precreate_vcpu
>
> pre-creation is very much specific to ARM right now. I am not sure
> if it is right to have an API with this name in the code which is
> common to other architectures.

I don't like exposing the concept of "parking" CPUs externally, which is 
so far handled completely internally.

[...]

> > kvm_create_vcpu
> > kvm_destroy_vcpu
> >
> > One could even make kvm_create_vcpu() fail on ARM if the VCPU hasn't
> > been pre-created.
>
> Right now, we abort the CPU initialization process if this happens. I
> am planning to change abort() into 'fatal_error' in RFC V3 though.
>
>
>
> > Or did I get it all wrong? :)
>
> I won't say that it is just another point of view which is absolutely
> fine. But I would like to stick to current APIs.

No really strong opinion, I wouldn't do it that way. I'll let others 
chime in if they have an opinion.

--
Cheers,

David / dhildenb