Re: [PATCH v2 3/6] hw/display/vga: Clean up global variable shadowing

[Philippe Mathieu-Daudé]

On 10/10/23 14:50, Philippe Mathieu-Daudé wrote:
> On 10/10/23 14:46, Ani Sinha wrote:
> > > On 10-Oct-2023, at 5:20 PM, Philippe Mathieu-Daudé 
> > > <philmd@linaro.org> wrote:
> > >
> > > Rename 'address_space' -> 'legacy_io' and
> > > 'address_space_io' -> 'io' to fix:
> >
> > This works but why not replace address_space with legacy_address_space 
> > instead?
>
> I'd rather avoid using 'address_space' for MemoryRegion, since we
> also have an AddressSpace type.
>
> Besides, both regions are mapped in I/O space.

That said, I should clarify that in the patch description.

> > >   hw/display/vga.c:2307:29: error: declaration shadows a variable in 
> > > the global scope [-Werror,-Wshadow]
> > >                 MemoryRegion *address_space_io, bool init_vga_ports)
> > >                             ^
> > >   include/exec/address-spaces.h:35:21: note: previous declaration is 
> > > here
> > >   extern AddressSpace address_space_io;
> > >                       ^
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > > hw/display/vga_int.h |  4 ++--
> > > hw/display/vga.c     | 12 ++++++------
> > > 2 files changed, 8 insertions(+), 8 deletions(-)