Re: [PULL 50/51] subprojects: add wrap file for libblkio

[Daniel P . Berrangé]

On Wed, Oct 11, 2023 at 04:58:01PM -0400, Stefan Hajnoczi wrote:
> On Wed, 11 Oct 2023 at 04:48, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Oct 11, 2023 at 07:35:24AM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi Paolo,
> > >
> > > On 7/9/23 14:59, Paolo Bonzini wrote:
> > > > This allows building libblkio at the same time as QEMU, if QEMU is
> > > > configured with --enable-blkio --enable-download.
> > > >
> > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > > ---
> > > >   subprojects/libblkio.wrap | 6 ++++++
> > > >   1 file changed, 6 insertions(+)
> > > >   create mode 100644 subprojects/libblkio.wrap
> > > >
> > > > diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
> > > > new file mode 100644
> > > > index 00000000000..f77af72210c
> > > > --- /dev/null
> > > > +++ b/subprojects/libblkio.wrap
> > > > @@ -0,0 +1,6 @@
> > > > +[wrap-git]
> > > > +url = https://gitlab.com/libblkio/libblkio
> > >
> > > Tyler noticed this project isn't mirrored on QEMU gitlab namespace.
> >
> > Many other wraps aren't mirrored either, and I'm not convinced we
> > need to, unless the project is on an obscure self hosted git service
> > which is thought unreliable.
> 
> What if upstream deletes the repository or sets visibility to
> "private"? Do GitHub and GitLab guarantee availability of previously
> public repositories?

No, there's no such guarantee. If it was a repo under a personal user
namespace mirroring is justified for this reason, but for a project
level namespace I feel we're protecting ourselves from a scenario
that's just never going to happen.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|