Re: [PATCH] hw/arm: Move raspberrypi-fw-defs.h to the include/hw/arm/ folder

[Philippe Mathieu-Daudé]

On 12/10/23 09:34, Thomas Huth wrote:
> The file is obviously related to the raspberrypi machine, so
> it should reside in hw/arm/ instead of hw/misc/.

Not quite. These are the VideoCore DSP definitions. Firmware
running on SoC including a VC can use this syscall-like interface.

FWIW there are a pair of QEMU VC implementations on GitHub.

Anyhow, preferably rewording the description,
Acked-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> And while we're
> at it, also adjust the wildcard in MAINTAINERS so that it covers
> this file, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   MAINTAINERS                                    | 2 +-
>   include/hw/{misc => arm}/raspberrypi-fw-defs.h | 0
>   hw/misc/bcm2835_property.c                     | 2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)
>   rename include/hw/{misc => arm}/raspberrypi-fw-defs.h (100%)