[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/13] tcg/ppc: Use PADDI in tcg_out_movi
|
From: |
Richard Henderson |
|
Subject: |
[PATCH v4 08/13] tcg/ppc: Use PADDI in tcg_out_movi |
|
Date: |
Fri, 13 Oct 2023 10:10:07 -0700 |
PADDI can load 34-bit immediates and 34-bit pc-relative addresses.
Reviewed-by: Jordan Niethe <jniethe5@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/ppc/tcg-target.c.inc | 51 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc
index 6337b1e8be..f4235383c6 100644
--- a/tcg/ppc/tcg-target.c.inc
+++ b/tcg/ppc/tcg-target.c.inc
@@ -719,6 +719,38 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
return true;
}
+/* Ensure that the prefixed instruction does not cross a 64-byte boundary. */
+static bool tcg_out_need_prefix_align(TCGContext *s)
+{
+ return ((uintptr_t)s->code_ptr & 0x3f) == 0x3c;
+}
+
+static void tcg_out_prefix_align(TCGContext *s)
+{
+ if (tcg_out_need_prefix_align(s)) {
+ tcg_out32(s, NOP);
+ }
+}
+
+static ptrdiff_t tcg_pcrel_diff_for_prefix(TCGContext *s, const void *target)
+{
+ return tcg_pcrel_diff(s, target) - (tcg_out_need_prefix_align(s) ? 4 : 0);
+}
+
+/* Output Type 10 Prefix - Modified Load/Store Form (MLS:D) */
+static void tcg_out_mls_d(TCGContext *s, tcg_insn_unit opc, unsigned rt,
+ unsigned ra, tcg_target_long imm, bool r)
+{
+ tcg_insn_unit p, i;
+
+ p = OPCD(1) | (2 << 24) | (r << 20) | ((imm >> 16) & 0x3ffff);
+ i = opc | TAI(rt, ra, imm);
+
+ tcg_out_prefix_align(s);
+ tcg_out32(s, p);
+ tcg_out32(s, i);
+}
+
static void tcg_out_mem_long(TCGContext *s, int opi, int opx, TCGReg rt,
TCGReg base, tcg_target_long offset);
@@ -1017,6 +1049,25 @@ static void tcg_out_movi_int(TCGContext *s, TCGType
type, TCGReg ret,
return;
}
+ /*
+ * Load values up to 34 bits, and pc-relative addresses,
+ * with one prefixed insn.
+ */
+ if (have_isa_3_10) {
+ if (arg == sextract64(arg, 0, 34)) {
+ /* pli ret,value = paddi ret,0,value,0 */
+ tcg_out_mls_d(s, ADDI, ret, 0, arg, 0);
+ return;
+ }
+
+ tmp = tcg_pcrel_diff_for_prefix(s, (void *)arg);
+ if (tmp == sextract64(tmp, 0, 34)) {
+ /* pla ret,value = paddi ret,0,value,1 */
+ tcg_out_mls_d(s, ADDI, ret, 0, tmp, 1);
+ return;
+ }
+ }
+
/* Load 32-bit immediates with two insns. Note that we've already
eliminated bare ADDIS, so we know both insns are required. */
if (TCG_TARGET_REG_BITS == 32 || arg == (int32_t)arg) {
--
2.34.1
- [PATCH v4 00/13] tcg/ppc: direct branching, power9, power10, Richard Henderson, 2023/10/13
- [PATCH v4 01/13] tcg/ppc: Untabify tcg-target.c.inc, Richard Henderson, 2023/10/13
- [PATCH v4 02/13] tcg/ppc: Enable direct branching tcg_out_goto_tb with TCG_REG_TB, Richard Henderson, 2023/10/13
- [PATCH v4 03/13] tcg/ppc: Reinterpret tb-relative to TB+4, Richard Henderson, 2023/10/13
- [PATCH v4 04/13] tcg/ppc: Use ADDPCIS in tcg_out_tb_start, Richard Henderson, 2023/10/13
- [PATCH v4 06/13] tcg/ppc: Use ADDPCIS for the constant pool, Richard Henderson, 2023/10/13
- [PATCH v4 07/13] tcg/ppc: Use ADDPCIS in tcg_out_goto_tb, Richard Henderson, 2023/10/13
- [PATCH v4 05/13] tcg/ppc: Use ADDPCIS in tcg_out_movi_int, Richard Henderson, 2023/10/13
- [PATCH v4 08/13] tcg/ppc: Use PADDI in tcg_out_movi,
Richard Henderson <=
- [PATCH v4 11/13] tcg/ppc: Use prefixed instructions in tcg_out_dupi_vec, Richard Henderson, 2023/10/13
- [PATCH v4 09/13] tcg/ppc: Use prefixed instructions in tcg_out_mem_long, Richard Henderson, 2023/10/13
- [PATCH v4 12/13] tcg/ppc: Use PLD in tcg_out_goto_tb, Richard Henderson, 2023/10/13
- [PATCH v4 13/13] tcg/ppc: Disable TCG_REG_TB for Power9/Power10, Richard Henderson, 2023/10/13
- [PATCH v4 10/13] tcg/ppc: Use PLD in tcg_out_movi for constant pool, Richard Henderson, 2023/10/13