Re: [PATCH 39/52] migration/rdma: Convert qemu_rdma_write_one() to Error

[Zhijian Li (Fujitsu)]

On 16/10/2023 20:11, Jason Gunthorpe wrote:
> On Sat, Oct 07, 2023 at 03:40:50AM +0000, Zhijian Li (Fujitsu) wrote:
>> +rdma-core
>>
>>
>> Is global variable *errno* reliable when the documentation only states
>> "returns 0 on success, or the value of errno on failure (which indicates the 
>> failure reason)."
> 
> I think the intention of this language was that an errno constant is
> returned, the caller should not assume it is stored in errno.
> 
Understood.
If that's the case, I think some pieces of code were misunderstood in QEMU 
before.


Thanks
Zhijian

> errno is difficult, many things overwrite it, you can loose its value
> during error handling.
> 
> Jason