qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost-user: Fix protocol feature bit conflict


From: Viresh Kumar
Subject: Re: [PATCH] vhost-user: Fix protocol feature bit conflict
Date: Tue, 17 Oct 2023 13:46:31 +0530

On 17-10-23, 10:14, Hanna Czenczek wrote:
> On 17.10.23 09:53, Viresh Kumar wrote:
> > On 17-10-23, 09:51, Hanna Czenczek wrote:
> > > Not that I’m really opposed to that, but I don’t see the problem with just
> > > doing that in the same work that makes qemu actually use this flag, 
> > > exactly
> > > because it’s just a -1/+1 change.

I should have replied here :)

> > > 
> > > I can send a v2, but should I do the same for libvhost-user and define the
> > > flag there?  Do I have to add a patch to do the same for F_STATUS, which 
> > > so
> > > far only got a placeholder comment?
> > Sure, that's fine too.
> 
> I would rather not, though, and don’t see a tangible benefit in doing so.

Sorry for the miscommunication, I meant we can leave it as is for now
and let it be handled by the commit that uses it.

-- 
viresh



reply via email to

[Prev in Thread] Current Thread [Next in Thread]