[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/22] vfio/ap: Remove pointless apdev variable
|
From: |
Cédric Le Goater |
|
Subject: |
[PULL 17/22] vfio/ap: Remove pointless apdev variable |
|
Date: |
Wed, 18 Oct 2023 11:45:26 +0200 |
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
No need to double-cast, call VFIO_AP_DEVICE() on DeviceState.
No functional changes.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/vfio/ap.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index
f870f51ffab4a637d2472db4fe4141ec7c54a470..5f257bffb9d2bfead9271bf2f4e3e3f610b78696
100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -156,8 +156,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
{
int ret;
Error *err = NULL;
- APDevice *apdev = AP_DEVICE(dev);
- VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev);
+ VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev);
VFIODevice *vbasedev = &vapdev->vdev;
vbasedev->name = g_path_get_basename(vbasedev->sysfsdev);
@@ -197,8 +196,7 @@ error:
static void vfio_ap_unrealize(DeviceState *dev)
{
- APDevice *apdev = AP_DEVICE(dev);
- VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev);
+ VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev);
vfio_ap_unregister_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX);
vfio_detach_device(&vapdev->vdev);
@@ -213,8 +211,7 @@ static Property vfio_ap_properties[] = {
static void vfio_ap_reset(DeviceState *dev)
{
int ret;
- APDevice *apdev = AP_DEVICE(dev);
- VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev);
+ VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev);
ret = ioctl(vapdev->vdev.fd, VFIO_DEVICE_RESET);
if (ret) {
--
2.41.0
- [PULL 02/22] linux-headers: Add iommufd.h, (continued)
- [PULL 02/22] linux-headers: Add iommufd.h, Cédric Le Goater, 2023/10/18
- [PULL 04/22] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any, Cédric Le Goater, 2023/10/18
- [PULL 01/22] scripts/update-linux-headers: Add iommufd.h, Cédric Le Goater, 2023/10/18
- [PULL 13/22] vfio/common: Store the parent container in VFIODevice, Cédric Le Goater, 2023/10/18
- [PULL 16/22] vfio/pci: Fix a potential memory leak in vfio_listener_region_add, Cédric Le Goater, 2023/10/18
- [PULL 06/22] vfio/common: Extract out vfio_kvm_device_[add/del]_fd, Cédric Le Goater, 2023/10/18
- [PULL 07/22] vfio/pci: Introduce vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/18
- [PULL 05/22] vfio/common: Introduce vfio_container_add|del_section_window(), Cédric Le Goater, 2023/10/18
- [PULL 03/22] vfio/common: Move IOMMU agnostic helpers to a separate file, Cédric Le Goater, 2023/10/18
- [PULL 12/22] vfio/common: Introduce a per container device list, Cédric Le Goater, 2023/10/18
- [PULL 17/22] vfio/ap: Remove pointless apdev variable,
Cédric Le Goater <=
- [PULL 11/22] vfio/common: Move VFIO reset handler registration to a group agnostic function, Cédric Le Goater, 2023/10/18
- [PULL 14/22] vfio/common: Introduce a global VFIODevice list, Cédric Le Goater, 2023/10/18
- [PULL 08/22] vfio/platform: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/18
- [PULL 09/22] vfio/ap: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/18
- [PULL 10/22] vfio/ccw: Use vfio_[attach/detach]_device, Cédric Le Goater, 2023/10/18
- [PULL 18/22] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW, Cédric Le Goater, 2023/10/18
- [PULL 19/22] vfio/pci: Remove vfio_detach_device from vfio_realize error path, Cédric Le Goater, 2023/10/18
- [PULL 20/22] ramfb: add migration support, Cédric Le Goater, 2023/10/18
- [PULL 15/22] vfio/common: Move legacy VFIO backend code into separate container.c, Cédric Le Goater, 2023/10/18
- [PULL 22/22] hw/vfio: add ramfb migration support, Cédric Le Goater, 2023/10/18