Re: [PATCH V5] migration: simplify blockers

[Steven Sistare]

On 10/18/2023 9:53 AM, Juan Quintela wrote:
> Steve Sistare <steven.sistare@oracle.com> wrote:
>> Modify migrate_add_blocker and migrate_del_blocker to take an Error **
>> reason.  This allows migration to own the Error object, so that if
>> an error occurs in migrate_add_blocker, migration code can free the Error
>> and clear the client handle, simplifying client code.  It also simplifies
>> the migrate_del_blocker call site.
>>
>> In addition, this is a pre-requisite for a proposed future patch that would
>> add a mode argument to migration requests to support live update, and
>> maintain a list of blockers for each mode.  A blocker may apply to a single
>> mode or to multiple modes, and passing Error** will allow one Error object
>> to be registered for multiple modes.
>>
>> No functional change.
>>
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> Tested-by: Michael Galaxy <mgalaxy@akamai.com>
>> Reviewed-by: Michael Galaxy <mgalaxy@akamai.com>
>> Reviewed-by: Peter Xu <peterx@redhat.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> Something weird happened with your rebase:
> 
> (next *|AM 1/1)$ find . -name "*rej"
> ./block/vpc.c.rej
> ./block/qcow.c.rej
> ./block/parallels.c.rej
> ./block/vdi.c.rej
> (next *|AM 1/1)$ 
> 
> trivial to fix, so I did it.
> 
> queued.

That's strange, thanks for the fixup!

- Steve