[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 00/11] Add VIRTIO sound card
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH v11 00/11] Add VIRTIO sound card |
|
Date: |
Wed, 18 Oct 2023 10:50:46 -0400 |
On Wed, Oct 18, 2023 at 04:44:00PM +0300, Manos Pitsidianakis wrote:
> Hello Michael,
>
> Thank you for your reply;
>
> On Wed, 18 Oct 2023 12:08, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > On Wed, Oct 18, 2023 at 11:49:00AM +0300, Manos Pitsidianakis wrote:
> > > On Wed, 11 Oct 2023 17:34, Manos Pitsidianakis
> > > <manos.pitsidianakis@linaro.org> wrote:
> > > > This patch series adds an audio device implementing the recent virtio
> > > > sound spec (1.2) and a corresponding PCI wrapper device.
> > > > > v11 can be found online at:
> > > > > https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v11
> > > > > Ref 885b01fe272541fdab5583780d4c3a59bfd8e734
> > > > Hello Gerd, MAINTAINERS says you own the hw/audio subsystem, would
> > > you pull
> > > this in your tree if/when it is to be merged?
> > >
> > > For context, the device was in hw/audio initially but in early list
> > > discussions we decided to move it with the rest of virtio devices.
> >
> > Link to these discussions? virtio-gpu is under ./hw/display
> > seems inconsistent.
>
> I agree that it is inconsistent, but I do not know if there is a general
> consensus on this. I am fine with placing it anywhere that is deemed
> appropriate.
>
> <87a5xkde0c.fsf@linaro.org>
> https://lore.kernel.org/qemu-devel/87a5xkde0c.fsf@linaro.org/
>
> > And you are asking Gerd to merge but
> > your MAINTAINERS patch wouldn't even let people know
> > he needs to be Cc'd on changes.
>
> No, I didn't ask to merge this, I asked if Gerd would be the one merging it
> because I am not sure myself and wanted more information. What do you think
> should be the correct process?
>
> --
I'd put it under audio and then you get an unambigous maintainer
to go through.
- [PATCH v11 02/11] Add virtio-sound-pci device, (continued)
- [PATCH v11 02/11] Add virtio-sound-pci device, Manos Pitsidianakis, 2023/10/11
- [PATCH v11 08/11] virtio-sound: handle VIRTIO_SND_R_PCM_RELEASE, Manos Pitsidianakis, 2023/10/11
- [PATCH v11 04/11] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request, Manos Pitsidianakis, 2023/10/11
- [PATCH v11 07/11] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE, Manos Pitsidianakis, 2023/10/11
- [PATCH v11 09/11] virtio-sound: implement audio output (TX), Manos Pitsidianakis, 2023/10/11
- [PATCH v11 10/11] virtio-sound: implement audio capture (RX), Manos Pitsidianakis, 2023/10/11
- [PATCH v11 11/11] docs/system: add basic virtio-snd documentation, Manos Pitsidianakis, 2023/10/11
- Re: [PATCH v11 00/11] Add VIRTIO sound card, Manos Pitsidianakis, 2023/10/18