Re: [PATCH v5 6/6] plugins: Remove an extra parameter

[Alex Bennée]

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> copy_call() has an unused parameter so remove it.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Queued to plugins/next, thanks.

> ---
>  accel/tcg/plugin-gen.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
> index 39b3c9351f..78b331b251 100644
> --- a/accel/tcg/plugin-gen.c
> +++ b/accel/tcg/plugin-gen.c
> @@ -327,8 +327,7 @@ static TCGOp *copy_st_ptr(TCGOp **begin_op, TCGOp *op)
>      return op;
>  }
>  
> -static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *empty_func,
> -                        void *func, int *cb_idx)
> +static TCGOp *copy_call(TCGOp **begin_op, TCGOp *op, void *func, int *cb_idx)
>  {
>      TCGOp *old_op;
>      int func_idx;
> @@ -372,8 +371,7 @@ static TCGOp *append_udata_cb(const struct 
> qemu_plugin_dyn_cb *cb,
>      }
>  
>      /* call */
> -    op = copy_call(&begin_op, op, HELPER(plugin_vcpu_udata_cb),
> -                   cb->f.vcpu_udata, cb_idx);
> +    op = copy_call(&begin_op, op, cb->f.vcpu_udata, cb_idx);
>  
>      return op;
>  }
> @@ -420,8 +418,7 @@ static TCGOp *append_mem_cb(const struct 
> qemu_plugin_dyn_cb *cb,
>  
>      if (type == PLUGIN_GEN_CB_MEM) {
>          /* call */
> -        op = copy_call(&begin_op, op, HELPER(plugin_vcpu_mem_cb),
> -                       cb->f.vcpu_udata, cb_idx);
> +        op = copy_call(&begin_op, op, cb->f.vcpu_udata, cb_idx);
>      }
>  
>      return op;


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro