[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple() |
|
Date: |
Fri, 20 Oct 2023 15:03:25 +0200 |
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/pcmcia/pxa2xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/pcmcia/pxa2xx.c b/hw/pcmcia/pxa2xx.c
index e7264feb45..3d512a292c 100644
--- a/hw/pcmcia/pxa2xx.c
+++ b/hw/pcmcia/pxa2xx.c
@@ -143,9 +143,7 @@ PXA2xxPCMCIAState *pxa2xx_pcmcia_init(MemoryRegion *sysmem,
{
DeviceState *dev;
- dev = qdev_new(TYPE_PXA2XX_PCMCIA);
- sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
- sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
+ dev = sysbus_create_simple(TYPE_PXA2XX_PCMCIA, base, NULL);
return PXA2XX_PCMCIA(dev);
}
--
2.41.0
- [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(),
Philippe Mathieu-Daudé <=
- [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Richard Henderson, 2023/10/21
- Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Peter Maydell, 2023/10/27