[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init()
|
From: |
Corey Minyard |
|
Subject: |
Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions |
|
Date: |
Mon, 23 Oct 2023 07:53:25 -0500 |
On Mon, Oct 23, 2023 at 01:30:09PM +0200, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
> > instance_init() can be called multiple times, e.g. during introspection
> > of the device. We should not install the vmstate handlers here. Do it
> > in the realize() function instead.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> It fixes my issues.
>
> Should I take this through the Migration tree?
That's fine with me.
Acked-by: Corey Minyard <cminyard@mvista.com>
>