[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ram_save_complete() is fishy
|
From: |
Peter Xu |
|
Subject: |
Re: ram_save_complete() is fishy |
|
Date: |
Tue, 24 Oct 2023 09:12:37 -0400 |
On Tue, Oct 24, 2023 at 11:05:12AM +0200, Thomas Huth wrote:
> Oh well, looking at the whole file, it seems like most spots that call a
> rdma_* function just do qemu_file_set_error() afterwards, but then continue
> with the normal workflow... that looks really confusing to me - if this
> needs fixing, it should be done by somebody who knows that code better than
> me, so I'll keep my hands of this and let somebody else fix it if necessary.
> I'll just respin my original patch to fix the -Wshadow issue.
Oh.. let me take a closer look today. Thanks for helping, Thomas!
--
Peter Xu