[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred()
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred() |
|
Date: |
Tue, 24 Oct 2023 14:40:34 -0300 |
Juan Quintela <quintela@redhat.com> writes:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/qemu-file.h | 18 ------------------
> migration/qemu-file.c | 7 -------
> 2 files changed, 25 deletions(-)
>
> diff --git a/migration/qemu-file.h b/migration/qemu-file.h
> index a29c37b0d0..8b71152754 100644
> --- a/migration/qemu-file.h
> +++ b/migration/qemu-file.h
> @@ -33,24 +33,6 @@ QEMUFile *qemu_file_new_input(QIOChannel *ioc);
> QEMUFile *qemu_file_new_output(QIOChannel *ioc);
> int qemu_fclose(QEMUFile *f);
>
> -/*
> - * qemu_file_transferred:
> - *
> - * Report the total number of bytes transferred with
> - * this file.
> - *
> - * For writable files, any pending buffers will be
> - * flushed, so the reported value will be equal to
> - * the number of bytes transferred on the wire.
> - *
> - * For readable files, the reported value will be
> - * equal to the number of bytes transferred on the
> - * wire.
> - *
> - * Returns: the total bytes transferred
> - */
> -uint64_t qemu_file_transferred(QEMUFile *f);
> -
> /*
> * qemu_file_transferred_noflush:
> *
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 641ab703cc..efa5f11033 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -632,13 +632,6 @@ uint64_t qemu_file_transferred_noflush(QEMUFile *f)
> return ret;
> }
>
> -uint64_t qemu_file_transferred(QEMUFile *f)
> -{
> - g_assert(qemu_file_is_writable(f));
> - qemu_fflush(f);
> - return stat64_get(&mig_stats.qemu_file_transferred);
> -}
> -
> void qemu_put_be16(QEMUFile *f, unsigned int v)
> {
> qemu_put_byte(f, v >> 8);
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 00/12] migration: Yet another round of atomic counters, Juan Quintela, 2023/10/24
- [PATCH 04/12] migration: Use the number of transferred bytes directly, Juan Quintela, 2023/10/24
- [PATCH 07/12] migration: migration_transferred_bytes() don't need the QEMUFile, Juan Quintela, 2023/10/24
- [PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side, Juan Quintela, 2023/10/24
- [PATCH 09/12] qemu-file: Simplify qemu_file_get_error(), Juan Quintela, 2023/10/24
- [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred, Juan Quintela, 2023/10/24
- [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred(), Juan Quintela, 2023/10/24
- Re: [PATCH 05/12] qemu_file: Remove unused qemu_file_transferred(),
Fabiano Rosas <=
- [PATCH 11/12] migration: Remove transferred atomic counter, Juan Quintela, 2023/10/24
- [PATCH 10/12] migration: Use migration_transferred_bytes(), Juan Quintela, 2023/10/24
- [PATCH 03/12] qemu_file: total_transferred is not used anymore, Juan Quintela, 2023/10/24
- [PATCH 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile, Juan Quintela, 2023/10/24
- [PATCH 12/12] qemu-file: Make qemu_fflush() return errors, Juan Quintela, 2023/10/24
- [PATCH 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush(), Juan Quintela, 2023/10/24