Re: [PATCH] hyperv: add check for NULL for msg

[Maciej S. Szmigiero]

On 26.10.2023 11:31, Анастасия Любимова wrote:
> 28/09/23 19:18, Maciej S. Szmigiero пишет:
> > On 28.09.2023 15:25, Anastasia Belova wrote:
> > > cpu_physical_memory_map may return NULL in hyperv_hcall_post_message.
> > > Add check for NULL to avoid NULL-dereference.
> > >
> > > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > >
> > > Fixes: 76036a5fc7 ("hyperv: process POST_MESSAGE hypercall")
> > > Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> >
> > Makes sense to me, thanks.
> >
> > Did you run your static checker through the remaining QEMU files,
> > too?
> >
> > I can see similar cpu_physical_memory_map() usage in, for example:
> > target/s390x/helper.c, hw/nvram/spapr_nvram.c, hw/hyperv/vmbus.c,
> > display/ramfb.c...
> It seems that configurations for analysis do not contain these files
> so the checker hasn't warned us. Additional time is needed to
> analyze these pieces of code and form patches if necessary.

No problem, it's not an urgent issue.  
> Anastasia Belova

Thanks,
Maciej