[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_s
|
From: |
Thomas Huth |
|
Subject: |
[PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_server_init() |
|
Date: |
Fri, 27 Oct 2023 11:37:00 +0200 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Rename the variable to fix:
softmmu/qtest.c:869:13: error: declaration shadows a variable in the global
scope [-Werror,-Wshadow]
Object *qtest;
^
softmmu/qtest.c:53:15: note: previous declaration is here
static QTest *qtest;
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-2-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
system/qtest.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/system/qtest.c b/system/qtest.c
index 35b643a274..7964f0b248 100644
--- a/system/qtest.c
+++ b/system/qtest.c
@@ -866,7 +866,7 @@ void qtest_server_init(const char *qtest_chrdev, const char
*qtest_log, Error **
{
ERRP_GUARD();
Chardev *chr;
- Object *qtest;
+ Object *qobj;
chr = qemu_chr_new("qtest", qtest_chrdev, NULL);
if (chr == NULL) {
@@ -875,18 +875,18 @@ void qtest_server_init(const char *qtest_chrdev, const
char *qtest_log, Error **
return;
}
- qtest = object_new(TYPE_QTEST);
- object_property_set_str(qtest, "chardev", chr->label, &error_abort);
+ qobj = object_new(TYPE_QTEST);
+ object_property_set_str(qobj, "chardev", chr->label, &error_abort);
if (qtest_log) {
- object_property_set_str(qtest, "log", qtest_log, &error_abort);
+ object_property_set_str(qobj, "log", qtest_log, &error_abort);
}
- object_property_add_child(qdev_get_machine(), "qtest", qtest);
- user_creatable_complete(USER_CREATABLE(qtest), errp);
+ object_property_add_child(qdev_get_machine(), "qtest", qobj);
+ user_creatable_complete(USER_CREATABLE(qobj), errp);
if (*errp) {
- object_unparent(qtest);
+ object_unparent(qobj);
}
object_unref(OBJECT(chr));
- object_unref(qtest);
+ object_unref(qobj);
}
static bool qtest_server_start(QTest *q, Error **errp)
--
2.41.0
- [PULL 00/11] testing patches (+ 1 deprecation patch), Thomas Huth, 2023/10/27
- [PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 02/11] tests/throttle: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 04/11] tests/cdrom-test: Clean up global variable shadowing in prepare_image(), Thomas Huth, 2023/10/27
- [PULL 05/11] tests/rtl8139: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_server_init(),
Thomas Huth <=
- [PULL 07/11] tests/aio: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 06/11] tests/npcm7xx_adc: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 08/11] tests/coroutine: Clean up global variable shadowing, Thomas Huth, 2023/10/27
- [PULL 09/11] docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated, Thomas Huth, 2023/10/27
- [PULL 10/11] tests/vm/freebsd: Add additional library paths for libfdt, Thomas Huth, 2023/10/27
- [PULL 11/11] ipmi-bt-test: force ipv4, Thomas Huth, 2023/10/27
- Re: [PULL 00/11] testing patches (+ 1 deprecation patch), Stefan Hajnoczi, 2023/10/30