[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 03/21] net: Move virtio-net header length assertion
|
From: |
Akihiko Odaki |
|
Subject: |
[PATCH v6 03/21] net: Move virtio-net header length assertion |
|
Date: |
Mon, 30 Oct 2023 14:12:24 +0900 |
The virtio-net header length assertion should happen for any clients.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
net/net.c | 5 +++++
net/tap.c | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/net.c b/net/net.c
index fda9a8f994..717d48ce15 100644
--- a/net/net.c
+++ b/net/net.c
@@ -56,6 +56,7 @@
#include "net/filter.h"
#include "qapi/string-output-visitor.h"
#include "qapi/qobject-input-visitor.h"
+#include "standard-headers/linux/virtio_net.h"
/* Net bridge is currently not supported for W32. */
#if !defined(_WIN32)
@@ -549,6 +550,10 @@ void qemu_set_vnet_hdr_len(NetClientState *nc, int len)
return;
}
+ assert(len == sizeof(struct virtio_net_hdr_mrg_rxbuf) ||
+ len == sizeof(struct virtio_net_hdr) ||
+ len == sizeof(struct virtio_net_hdr_v1_hash));
+
nc->vnet_hdr_len = len;
nc->info->set_vnet_hdr_len(nc, len);
}
diff --git a/net/tap.c b/net/tap.c
index 0e031ee9fa..d94731b2fa 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -274,9 +274,6 @@ static void tap_set_vnet_hdr_len(NetClientState *nc, int
len)
TAPState *s = DO_UPCAST(TAPState, nc, nc);
assert(nc->info->type == NET_CLIENT_DRIVER_TAP);
- assert(len == sizeof(struct virtio_net_hdr_mrg_rxbuf) ||
- len == sizeof(struct virtio_net_hdr) ||
- len == sizeof(struct virtio_net_hdr_v1_hash));
tap_fd_set_vnet_hdr_len(s->fd, len);
s->host_vnet_hdr_len = len;
--
2.42.0
- [PATCH v6 00/21] virtio-net RSS/hash report fixes and improvements, Akihiko Odaki, 2023/10/30
- [PATCH v6 02/21] tap: Remove qemu_using_vnet_hdr(), Akihiko Odaki, 2023/10/30
- [PATCH v6 01/21] tap: Remove tap_probe_vnet_hdr_len(), Akihiko Odaki, 2023/10/30
- [PATCH v6 03/21] net: Move virtio-net header length assertion,
Akihiko Odaki <=
- [PATCH v6 04/21] net: Remove receive_raw(), Akihiko Odaki, 2023/10/30
- [PATCH v6 05/21] tap: Remove tap_receive(), Akihiko Odaki, 2023/10/30
- [PATCH v6 06/21] net: Remove flag propagation, Akihiko Odaki, 2023/10/30
- [PATCH v6 07/21] tap: Shrink zeroed virtio-net header, Akihiko Odaki, 2023/10/30
- [PATCH v6 08/21] virtio-net: Copy header only when necessary, Akihiko Odaki, 2023/10/30
- [PATCH v6 09/21] virtio-net: Disable RSS on reset, Akihiko Odaki, 2023/10/30
- [PATCH v6 10/21] virtio-net: Unify the logic to update NIC state for RSS, Akihiko Odaki, 2023/10/30
- [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS, Akihiko Odaki, 2023/10/30