[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/12] hw/arm/xlnx-versal: Use qdev_prop_set_array()
|
From: |
Kevin Wolf |
|
Subject: |
[PATCH v2 08/12] hw/arm/xlnx-versal: Use qdev_prop_set_array() |
|
Date: |
Mon, 30 Oct 2023 15:26:54 +0100 |
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/xlnx-versal.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
index fa556d8764..d0f6235d4f 100644
--- a/hw/arm/xlnx-versal.c
+++ b/hw/arm/xlnx-versal.c
@@ -12,6 +12,7 @@
#include "qemu/osdep.h"
#include "qemu/units.h"
#include "qapi/error.h"
+#include "qapi/qmp/qlist.h"
#include "qemu/module.h"
#include "hw/sysbus.h"
#include "net/net.h"
@@ -69,6 +70,7 @@ static void versal_create_apu_gic(Versal *s, qemu_irq *pic)
};
SysBusDevice *gicbusdev;
DeviceState *gicdev;
+ QList *redist_region_count;
int nr_apu_cpus = ARRAY_SIZE(s->fpd.apu.cpu);
int i;
@@ -79,8 +81,11 @@ static void versal_create_apu_gic(Versal *s, qemu_irq *pic)
qdev_prop_set_uint32(gicdev, "revision", 3);
qdev_prop_set_uint32(gicdev, "num-cpu", nr_apu_cpus);
qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32);
- qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1);
- qdev_prop_set_uint32(gicdev, "redist-region-count[0]", nr_apu_cpus);
+
+ redist_region_count = qlist_new();
+ qlist_append_int(redist_region_count, nr_apu_cpus);
+ qdev_prop_set_array(gicdev, "redist-region-count", redist_region_count);
+
qdev_prop_set_bit(gicdev, "has-security-extensions", true);
sysbus_realize(SYS_BUS_DEVICE(&s->fpd.apu.gic), &error_fatal);
--
2.41.0
- [PATCH v2 03/12] hw/arm/mps2-tz: Use qdev_prop_set_array(), (continued)
- [PATCH v2 03/12] hw/arm/mps2-tz: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 02/12] hw/i386/pc: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 07/12] hw/arm/virt: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 10/12] qom: Add object_property_set_default_list(), Kevin Wolf, 2023/10/30
- [PATCH v2 11/12] qdev: Make netdev properties work as list elements, Kevin Wolf, 2023/10/30
- [PATCH v2 09/12] hw/rx/rx62n: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 05/12] hw/arm/sbsa-ref: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 12/12] qdev: Rework array properties based on list visitor, Kevin Wolf, 2023/10/30
- [PATCH v2 06/12] hw/arm/vexpress: Use qdev_prop_set_array(), Kevin Wolf, 2023/10/30
- [PATCH v2 08/12] hw/arm/xlnx-versal: Use qdev_prop_set_array(),
Kevin Wolf <=