qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/8] qemu-img: rebase: stop when reaching EOF of old backi


From: Michael Tokarev
Subject: Re: [PATCH v3 1/8] qemu-img: rebase: stop when reaching EOF of old backing file
Date: Wed, 1 Nov 2023 12:50:16 +0300
User-agent: Mozilla Thunderbird

19.09.2023 19:57, Andrey Drobyshev via wrote:
In case when we're rebasing within one backing chain, and when target image
is larger than old backing file, bdrv_is_allocated_above() ends up setting
*pnum = 0.  As a result, target offset isn't getting incremented, and we
get stuck in an infinite for loop.  Let's detect this case and proceed
further down the loop body, as the offsets beyond the old backing size need
to be explicitly zeroed.

Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>

Is this change not for -stable anymore?  First version of this patch has been
Cc'd to stable, this one is not.

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]