[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `mach
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `machine` |
Date: |
Thu, 02 Nov 2023 07:59:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Dinah B <dinahbaum123@gmail.com> writes:
> Hi,
>
> I noticed that qapi now has a machine-common category - do you think these
> changes would be more appropriate in that file
> rather than "machine" for the revision?
You're right.
We created machine-common.json for stuff needed by both machine.json and
machine-target.json. The alternative was to have machine-target.json
include machine.json instead. When we discussed which alternative to
pick, I didn't remember your patch adds the include.
Picking both makes no sense. Please look into adding stuff in a way
that avoids the include.
Thanks for paying attention!
> Thanks and sorry for the delay,
I'm not in a hurry here :)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `machine`,
Markus Armbruster <=