[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/qapi-schema: Tidy up pylint warnings and advice
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] tests/qapi-schema: Tidy up pylint warnings and advice |
|
Date: |
Fri, 03 Nov 2023 06:33:37 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> Pylint warns:
>
> tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without
> explicitly specifying an encoding (unspecified-encoding)
> tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without
> explicitly specifying an encoding (unspecified-encoding)
>
> Add encoding='utf-8'.
>
> Pylint advises:
>
> tests/qapi-schema/test-qapi.py:143:13: R1732: Consider using 'with' for
> resource-allocating operations (consider-using-with)
>
> Silence this by returning the value directly.
>
> Pylint advises:
>
> tests/qapi-schema/test-qapi.py:221:4: R1722: Consider using sys.exit()
> (consider-using-sys-exit)
> tests/qapi-schema/test-qapi.py:226:4: R1722: Consider using sys.exit()
> (consider-using-sys-exit)
>
> Sure, why not.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Queued.