[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/21] target/sparc: Do flush_cond in advance_jump_cond
|
From: |
Richard Henderson |
|
Subject: |
[PULL 12/21] target/sparc: Do flush_cond in advance_jump_cond |
|
Date: |
Sun, 5 Nov 2023 12:12:13 -0800 |
Do this here instead of in each caller.
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sparc/translate.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index dd6d43d1f1..2e7deb5e33 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -2407,7 +2407,10 @@ static bool advance_jump_uncond_always(DisasContext *dc,
bool annul,
static bool advance_jump_cond(DisasContext *dc, DisasCompare *cmp,
bool annul, target_ulong dest)
{
- target_ulong npc = dc->npc;
+ target_ulong npc;
+
+ flush_cond(dc);
+ npc = dc->npc;
if (annul) {
TCGLabel *l1 = gen_new_label();
@@ -2481,8 +2484,6 @@ static bool do_bpcc(DisasContext *dc, arg_bcc *a)
case 0x8:
return advance_jump_uncond_always(dc, a->a, target);
default:
- flush_cond(dc);
-
gen_compare(&cmp, a->cc, a->cond, dc);
return advance_jump_cond(dc, &cmp, a->a, target);
}
@@ -2505,8 +2506,6 @@ static bool do_fbpfcc(DisasContext *dc, arg_bcc *a)
case 0x8:
return advance_jump_uncond_always(dc, a->a, target);
default:
- flush_cond(dc);
-
gen_fcompare(&cmp, a->cc, a->cond);
return advance_jump_cond(dc, &cmp, a->a, target);
}
@@ -2527,7 +2526,6 @@ static bool trans_BPr(DisasContext *dc, arg_BPr *a)
return false;
}
- flush_cond(dc);
gen_compare_reg(&cmp, a->cond, gen_load_gpr(dc, a->rs1));
return advance_jump_cond(dc, &cmp, a->a, target);
}
--
2.34.1
- [PULL 01/21] target/sparc: Introduce cpu_put_psr_icc, (continued)
- [PULL 01/21] target/sparc: Introduce cpu_put_psr_icc, Richard Henderson, 2023/11/05
- [PULL 03/21] target/sparc: Remove CC_OP_LOGIC, Richard Henderson, 2023/11/05
- [PULL 02/21] target/sparc: Split psr and xcc into components, Richard Henderson, 2023/11/05
- [PULL 06/21] target/sparc: Remove CC_OP_SUB, CC_OP_SUBX, CC_OP_TSUB, Richard Henderson, 2023/11/05
- [PULL 05/21] target/sparc: Remove CC_OP_ADD, CC_OP_ADDX, CC_OP_TADD, Richard Henderson, 2023/11/05
- [PULL 07/21] target/sparc: Remove CC_OP_TADDTV, CC_OP_TSUBTV, Richard Henderson, 2023/11/05
- [PULL 09/21] target/sparc: Remove DisasCompare.is_bool, Richard Henderson, 2023/11/05
- [PULL 08/21] target/sparc: Remove CC_OP leftovers, Richard Henderson, 2023/11/05
- [PULL 10/21] target/sparc: Change DisasCompare.c2 to int, Richard Henderson, 2023/11/05
- [PULL 11/21] target/sparc: Always copy conditions into a new temporary, Richard Henderson, 2023/11/05
- [PULL 12/21] target/sparc: Do flush_cond in advance_jump_cond,
Richard Henderson <=
- [PULL 13/21] target/sparc: Merge gen_branch2 into advance_pc, Richard Henderson, 2023/11/05
- [PULL 14/21] target/sparc: Merge advance_jump_uncond_{never, always} into advance_jump_cond, Richard Henderson, 2023/11/05
- [PULL 16/21] target/sparc: Merge gen_op_next_insn into only caller, Richard Henderson, 2023/11/05
- [PULL 17/21] target/sparc: Record entire jump condition in DisasContext, Richard Henderson, 2023/11/05
- [PULL 15/21] target/sparc: Pass displacement to advance_jump_cond, Richard Henderson, 2023/11/05
- [PULL 04/21] target/sparc: Remove CC_OP_DIV, Richard Henderson, 2023/11/05
- [PULL 18/21] target/sparc: Discard cpu_cond at the end of each insn, Richard Henderson, 2023/11/05
- [PULL 19/21] target/sparc: Implement UDIVX and SDIVX inline, Richard Henderson, 2023/11/05
- [PULL 20/21] target/sparc: Implement UDIV inline, Richard Henderson, 2023/11/05
- [PULL 21/21] target/sparc: Check for invalid cond in gen_compare_reg, Richard Henderson, 2023/11/05