[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/10] Revert "virtio-gpu: block migration of VMs with blob=true"
|
From: |
marcandre . lureau |
|
Subject: |
[PULL 10/10] Revert "virtio-gpu: block migration of VMs with blob=true" |
|
Date: |
Mon, 6 Nov 2023 17:32:19 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
If we decide to apply this patch (for easier backporting reasons), we
can now revert it.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
---
hw/display/virtio-gpu.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 1ab662db72..2707bceea8 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -26,7 +26,6 @@
#include "hw/virtio/virtio-gpu-pixman.h"
#include "hw/virtio/virtio-bus.h"
#include "hw/qdev-properties.h"
-#include "migration/blocker.h"
#include "qemu/log.h"
#include "qemu/module.h"
#include "qapi/error.h"
@@ -41,8 +40,6 @@ virtio_gpu_find_check_resource(VirtIOGPU *g, uint32_t
resource_id,
static void virtio_gpu_reset_bh(void *opaque);
-static Error *blob_mig_blocker;
-
void virtio_gpu_update_cursor_data(VirtIOGPU *g,
struct virtio_gpu_scanout *s,
uint32_t resource_id)
@@ -1463,14 +1460,6 @@ void virtio_gpu_device_realize(DeviceState *qdev, Error
**errp)
error_setg(errp, "blobs and virgl are not compatible (yet)");
return;
}
-
- if (!blob_mig_blocker) {
- error_setg(&blob_mig_blocker,
- "virtio-gpu blob VMs are currently not migratable.");
- }
- if (migrate_add_blocker(blob_mig_blocker, errp)) {
- return;
- }
}
if (!virtio_gpu_base_device_realize(qdev,
@@ -1497,9 +1486,6 @@ static void virtio_gpu_device_unrealize(DeviceState *qdev)
{
VirtIOGPU *g = VIRTIO_GPU(qdev);
- if (virtio_gpu_blob_enabled(g->parent_obj.conf)) {
- migrate_del_blocker(blob_mig_blocker);
- }
g_clear_pointer(&g->ctrl_bh, qemu_bh_delete);
g_clear_pointer(&g->cursor_bh, qemu_bh_delete);
g_clear_pointer(&g->reset_bh, qemu_bh_delete);
--
2.41.0
- [PULL 00/10] Gpu patches, marcandre . lureau, 2023/11/06
- [PULL 01/10] virtio-gpu-rutabaga: Add empty interface to fix arm64 crash, marcandre . lureau, 2023/11/06
- [PULL 02/10] ati-vga: Fix aperture sizes, marcandre . lureau, 2023/11/06
- [PULL 03/10] ati-vga: Support unaligned access to GPIO DDC registers, marcandre . lureau, 2023/11/06
- [PULL 04/10] ati-vga: Add 30 bit palette access register, marcandre . lureau, 2023/11/06
- [PULL 05/10] ati-vga: Implement fallback for pixman routines, marcandre . lureau, 2023/11/06
- [PULL 06/10] virtio-gpu: block migration of VMs with blob=true, marcandre . lureau, 2023/11/06
- [PULL 07/10] virtio-gpu: factor out restore mapping, marcandre . lureau, 2023/11/06
- [PULL 08/10] virtio-gpu: move scanout restoration to post_load, marcandre . lureau, 2023/11/06
- [PULL 10/10] Revert "virtio-gpu: block migration of VMs with blob=true",
marcandre . lureau <=
- [PULL 09/10] virtio-gpu: add virtio-gpu/blob vmstate subsection, marcandre . lureau, 2023/11/06
- Re: [PULL 00/10] Gpu patches, Stefan Hajnoczi, 2023/11/06