Re: [PATCH v2 01/35] tcg: Introduce TCG_COND_TST{EQ,NE}

[Philippe Mathieu-Daudé]

On 28/10/23 21:44, Richard Henderson wrote:
> Add the enumerators, adjust the helpers to match, and dump.
> Not supported anywhere else just yet.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   docs/devel/tcg-ops.rst |  2 ++
>   include/tcg/tcg-cond.h | 49 ++++++++++++++++++++++++++++++++----------
>   tcg/tcg.c              |  4 +++-
>   3 files changed, 43 insertions(+), 12 deletions(-)


> diff --git a/include/tcg/tcg-cond.h b/include/tcg/tcg-cond.h
> index 2a38a386d4..bf3fcf5968 100644
> --- a/include/tcg/tcg-cond.h
> +++ b/include/tcg/tcg-cond.h
> @@ -49,6 +49,9 @@ typedef enum {

Maybe update the enum comment, otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       TCG_COND_GEU    = 0 | 4 | 0 | 1,
>       TCG_COND_LEU    = 8 | 4 | 0 | 0,
>       TCG_COND_GTU    = 8 | 4 | 0 | 1,
> +    /* "test" i.e. and then compare vs 0 */
> +    TCG_COND_TSTEQ  = 8 | 4 | 2 | 0,
> +    TCG_COND_TSTNE  = 8 | 4 | 2 | 1,
>   } TCGCond;