Re: [External] Re: [PATCH 09/16] migration/multifd: Add new migration option for multifd DSA offloading.

[Hao Xiang]

On Mon, Oct 30, 2023 at 7:41 AM Fabiano Rosas <farosas@suse.de> wrote:
>
> Hao Xiang <hao.xiang@bytedance.com> writes:
>
> > Intel DSA offloading is an optional feature that turns on if
> > proper hardware and software stack is available. To turn on
> > DSA offloading in multifd live migration:
> >
> > multifd-dsa-accel="[dsa_dev_path1] ] [dsa_dev_path2] ... [dsa_dev_pathX]"
> >
> > This feature is turned off by default.
>
> This patch looks fine. However I wonder if wouldn't it be better to not
> couple dsa with multifd in the capability name? I.e. we could add just a
> dsa capability and have a check saying that it currently only works with
> multifd.
>

I will keep that option open. Right now, it's only used in multifd
migration. If we want to use DSA offloading in other scenarios, we can
add new switches for those scenarios.