[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/63] vhost-user.rst: Introduce suspended state
|
From: |
Michael S. Tsirkin |
|
Subject: |
[PULL 03/63] vhost-user.rst: Introduce suspended state |
|
Date: |
Tue, 7 Nov 2023 05:09:38 -0500 |
From: Hanna Czenczek <hreitz@redhat.com>
In vDPA, GET_VRING_BASE does not stop the queried vring, which is why
SUSPEND was introduced so that the returned index would be stable. In
vhost-user, it does stop the vring, so under the same reasoning, it can
get away without SUSPEND.
Still, we do want to clarify that if the device is completely stopped,
i.e. all vrings are stopped, the back-end should cease to modify any
state relating to the guest. Do this by calling it "suspended".
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20231016134243.68248-4-hreitz@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
docs/interop/vhost-user.rst | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index e5a04c04ed..035a23ed35 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -442,6 +442,19 @@ back-end must enable all rings immediately.
While processing the rings (whether they are enabled or not), the back-end
must support changing some configuration aspects on the fly.
+.. _suspended_device_state:
+
+Suspended device state
+^^^^^^^^^^^^^^^^^^^^^^
+
+While all vrings are stopped, the device is *suspended*. In addition to
+not processing any vring (because they are stopped), the device must:
+
+* not write to any guest memory regions,
+* not send any notifications to the guest,
+* not send any messages to the front-end,
+* still process and reply to messages from the front-end.
+
Multiple queue support
----------------------
@@ -529,7 +542,8 @@ ancillary data, it may be used to inform the front-end that
the log has
been modified.
Once the source has finished migration, rings will be stopped by the
-source. No further update must be done before rings are restarted.
+source (:ref:`Suspended device state <suspended_device_state>`). No
+further update must be done before rings are restarted.
In postcopy migration the back-end is started before all the memory has
been received from the source host, and care must be taken to avoid
@@ -1123,6 +1137,10 @@ Front-end message types
(*a vring descriptor index for split virtqueues* vs. *vring descriptor
indices for packed virtqueues*).
+ When and as long as all of a device’s vrings are stopped, it is
+ *suspended*, see :ref:`Suspended device state
+ <suspended_device_state>`.
+
The request payload’s *num* field is currently reserved and must be
set to 0.
--
MST
- [PULL 00/63] virtio,pc,pci: features, fixes, Michael S. Tsirkin, 2023/11/07
- [PULL 01/63] vhost-user.rst: Improve [GS]ET_VRING_BASE doc, Michael S. Tsirkin, 2023/11/07
- [PULL 02/63] vhost-user.rst: Clarify enabling/disabling vrings, Michael S. Tsirkin, 2023/11/07
- [PULL 03/63] vhost-user.rst: Introduce suspended state,
Michael S. Tsirkin <=
- [PULL 06/63] vhost: Add high-level state save/load functions, Michael S. Tsirkin, 2023/11/07
- [PULL 07/63] vhost-user-fs: Implement internal migration, Michael S. Tsirkin, 2023/11/07
- [PULL 11/63] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request, Michael S. Tsirkin, 2023/11/07
- [PULL 05/63] vhost-user: Interface for migration state transfer, Michael S. Tsirkin, 2023/11/07
- [PULL 04/63] vhost-user.rst: Migrating back-end-internal state, Michael S. Tsirkin, 2023/11/07
- [PULL 12/63] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}, Michael S. Tsirkin, 2023/11/07
- [PULL 08/63] Add virtio-sound device stub, Michael S. Tsirkin, 2023/11/07