Re: [PULL 3/8] dump: Add command interface for kdump-raw formats

[Markus Armbruster]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 3 Nov 2023 at 07:02, <marcandre.lureau@redhat.com> wrote:
>>
>> From: Stephen Brennan <stephen.s.brennan@oracle.com>
>>
>> The QMP dump API represents the dump format as an enumeration. Add three
>> new enumerators, one for each supported kdump compression, each named
>> "kdump-raw-*".
>>
>> For the HMP command line, rather than adding a new flag corresponding to
>> each format, it seems more human-friendly to add a single flag "-R" to
>> switch the kdump formats to "raw" mode. The choice of "-R" also
>> correlates nicely to the "makedumpfile -R" option, which would serve to
>> reassemble a flattened vmcore.
>>
>> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> [ Marc-André: replace loff_t with off_t, indent fixes ]
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Message-Id: <20230918233233.1431858-4-stephen.s.brennan@oracle.com>
>
> Hi; Coverity points out some issues in this commit:

Proposed fixes:

    Subject: [PATCH 0/2] dump: Fix issues flagged by Coverity
    Message-ID: <20231108053731.112043-1-armbru@redhat.com>