qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info
Date: Wed, 8 Nov 2023 11:22:16 +0100
User-agent: Mozilla Thunderbird

On 26/10/23 23:19, Dongli Zhang wrote:
While the default "info lapic" always synchronizes cpu state ...

mon_get_cpu()
-> mon_get_cpu_sync(mon, true)
    -> cpu_synchronize_state(cpu)
       -> ioctl KVM_GET_LAPIC (taking KVM as example)

... the cpu state is not synchronized when the apic-id is available as
argument.

The cpu state should be synchronized when apic-id is available. Otherwise
the "info lapic <apic-id>" always returns stale data.

Reference:
https://lore.kernel.org/all/20211028155457.967291-19-berrange@redhat.com/

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
---
Changed since v1:
   - I sent out wrong patch version in v1
Changed since v2:
   - Add the Reviewed-by from Daniel and David

  target/i386/monitor.c | 5 +++++
  1 file changed, 5 insertions(+)

Patch queued via my cpu/misc tree, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]