Re: [PATCH v3 00/20] first version of mcdstub

[Philippe Mathieu-Daudé]

Hi Nicolas,

On 7/11/23 14:03, Nicolas Eder wrote:
> SUMMARY
> =======
>
> This patch-set introduces the first version of the mcdstub.


>   30 files changed, 3749 insertions(+), 38 deletions(-)
>   create mode 100644 debug/debug-common.c
>   create mode 100644 debug/debug-gdb.c
>   create mode 100644 debug/debug-mcd.c
>   create mode 100644 include/cutils.h
>   create mode 100644 include/mcdstub/arm_mcdstub.h
>   create mode 100644 include/mcdstub/mcd_shared_defines.h
>   create mode 100644 include/mcdstub/mcdstub.h
>   create mode 100644 include/mcdstub/mcdstub_common.h
>   create mode 100644 include/qemu/debug.h
>   create mode 100644 mcdstub/mcdstub.c
>   create mode 100644 mcdstub/meson.build
>   create mode 100644 target/arm/mcdstub.c

These files are missing a license. Adding:
/* SPDX-License-Identifier: GPL-2.0-or-later */
on the first line is usually enough.

No need to respin a v4 yet, let's wait for technical
comments on your patches.

Regards,

Phil.