Re: [PATCH v2 20/35] tcg/sparc64: Hoist read of tcg_cond_to_rcond

[Philippe Mathieu-Daudé]

On 8/11/23 21:57, Richard Henderson wrote:
> On 11/6/23 13:02, Philippe Mathieu-Daudé wrote:
> > On 28/10/23 21:45, Richard Henderson wrote:
> > > Use a non-zero value here (an illegal encoding) as a better
> > > condition than is_unsigned_cond for when MOVR/BPR is usable.
> > >
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > > ---
> > >   tcg/sparc64/tcg-target.c.inc | 25 ++++++++++++++-----------
> > >   1 file changed, 14 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc
> > > index ac86b92b75..e16b25e309 100644
> > > --- a/tcg/sparc64/tcg-target.c.inc
> > > +++ b/tcg/sparc64/tcg-target.c.inc
> > > @@ -620,7 +620,7 @@ static const uint8_t tcg_cond_to_bcond[] = {
> > >       [TCG_COND_GTU] = COND_GU,
> > >   };
> > > -static const uint8_t tcg_cond_to_rcond[] = {
> > > +static const uint8_t tcg_cond_to_rcond[16] = {
> >
> >
> > > -static void tcg_out_movr(TCGContext *s, TCGCond cond, TCGReg ret, 
> > > TCGReg c1,
> > > +static void tcg_out_movr(TCGContext *s, int rcond, TCGReg ret, 
> > > TCGReg c1,
> >
> > Isn't rcond unsigned?
>
> Yes, though it is in [0-7], so it doesn't matter.

Maybe using 'uint8_t' would be clearer. Just suggesting, not a blocker.