[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array()
|
From: |
Kevin Wolf |
|
Subject: |
[PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array() |
|
Date: |
Thu, 9 Nov 2023 18:42:30 +0100 |
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/i386/pc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 188bc9d0f8..29b9964733 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -44,6 +44,7 @@
#include "sysemu/reset.h"
#include "kvm/kvm_i386.h"
#include "hw/xen/xen.h"
+#include "qapi/qmp/qlist.h"
#include "qemu/error-report.h"
#include "hw/acpi/cpu_hotplug.h"
#include "acpi-build.h"
@@ -1457,10 +1458,11 @@ static void
pc_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,
/* Declare the APIC range as the reserved MSI region */
char *resv_prop_str = g_strdup_printf("0xfee00000:0xfeefffff:%d",
VIRTIO_IOMMU_RESV_MEM_T_MSI);
+ QList *reserved_regions = qlist_new();
+
+ qlist_append_str(reserved_regions, resv_prop_str);
+ qdev_prop_set_array(dev, "reserved-regions", reserved_regions);
- object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp);
- object_property_set_str(OBJECT(dev), "reserved-regions[0]",
- resv_prop_str, errp);
g_free(resv_prop_str);
}
--
2.41.0
- [PATCH v3 00/11] qdev: Make array properties user accessible again, Kevin Wolf, 2023/11/09
- [PATCH v3 02/11] hw/arm/mps2-tz: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 03/11] hw/arm/mps2: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 01/11] hw/i386/pc: Use qdev_prop_set_array(),
Kevin Wolf <=
- [PATCH v3 04/11] hw/arm/sbsa-ref: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 05/11] hw/arm/vexpress: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 07/11] hw/arm/xlnx-versal: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 06/11] hw/arm/virt: Use qdev_prop_set_array(), Kevin Wolf, 2023/11/09
- [PATCH v3 09/11] qom: Add object_property_set_default_list(), Kevin Wolf, 2023/11/09
- [PATCH v3 10/11] qdev: Make netdev properties work as list elements, Kevin Wolf, 2023/11/09
- [PATCH v3 11/11] qdev: Rework array properties based on list visitor, Kevin Wolf, 2023/11/09